Basis variables independence #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShantanuThakoor
requested review from
guykatzz and
ibeling
and removed request for
ibeling
|
Hi Shantanu, A few more comments:
|
|
I've written a simple test making sure that we are always selecting linearly independent columns as we do the Gaussian elimination. |
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Better choosing of basic variables * Fixed max relu tests * Simpler way to keep track of independent columns * Fixed test asserting auxiliary vars are basic * cosmetics * added mock infrastructure for ConstraintMatrixAnalyzer in order to fix the failing unit test * Test that linearly independent rows of full-rank A matrix chosen as B0 * Add constraint analyzer factory to makefile in maraboupy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConstraintMatrixAnalyzer now keeps track of independent columns as we do GaussianElimination.
Use these columns to define initial set of basic variables.
Included regress test involving max and relu constraints together, for which this fix was needed.