Proper symbolic bound tightening for Signs #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from master
Merge from master
guyam2
reviewed
Sep 13, 2020
src/nlr/Layer.cpp
Outdated
| There are two ways we can determine that a Sign has become fixed: | ||
|
|
||
| 1. If the Sign's variable has been externally fixed | ||
| 2. lbLb >= 0 (Positive) or ubUb <= 0 (Negative) |
There was a problem hiding this comment.
@guykatzz if up<=0 then there is no fix because the function is non-continuous
There was a problem hiding this comment.
Not sure I understand. Fixed here means phase fixed - if ubOfUb is negative (should be <, not <=, in the comment), then the upper bound is negative, and the Sign is in the negative phase.
guyam2
approved these changes
Sep 14, 2020
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* support SBT for signs * bug fix * minor Co-authored-by: Guy Katz <guykatz@cs.huji.ac.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.