Add context-dependent data structures from CVC4 #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: cvc4_private*.h is overwritten by cvc4_public.h, since Marabou won't make this distinction. Co-authored-by: anwu1219 <haozewu@stanford.edu> Co-authored-by: ahmed-irfan <irfan@cs.stanford.edu>
Group dependency related instructions Enable SYSTEM designation for dependencies to remove warnings in 3rd party code
ahmed-irfan
reviewed
Nov 2, 2020
ahmed-irfan
reviewed
Nov 2, 2020
wu-haoze
reviewed
Nov 2, 2020
CMakeLists.txt
Outdated
| @@ -28,6 +28,8 @@ set(MARABOU_TEST_LIB MarabouHelperTest) | |||
| set(MARABOU_EXE Marabou${CMAKE_EXECUTABLE_SUFFIX}) | |||
| set(MARABOU_PY MarabouCore) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
There are some extra spaces and empty lines in this file.
There was a problem hiding this comment.
Thanks, will make spacing uniform throughout the file.
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Add Context and Base into Deps/CVC4 * Add dependencies to CMakeLists.txt * Add CVC4 dependencies and CMAKE compile Note: cvc4_private*.h is overwritten by cvc4_public.h, since Marabou won't make this distinction. Co-authored-by: anwu1219 <haozewu@stanford.edu> Co-authored-by: ahmed-irfan <irfan@cs.stanford.edu> * Fix ... syntax in variadic Macros (For Windows compiler) * Move CVC4 dependencies into top level CMakeLists.txt Group dependency related instructions Enable SYSTEM designation for dependencies to remove warnings in 3rd party code * Redefine __PRETTY_FUNCTION__ to __FUNCSIG___ on Windows * Fix empty lines in top level CMakeLists.txt * Fix edited CVC4 headers to adhere to notation and copyright Co-authored-by: anwu1219 <haozewu@stanford.edu> Co-authored-by: ahmed-irfan <irfan@cs.stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First in a series of PRs to intriduce context-dependent search implementation in Marabou.
Add context-dependent (CD) data structures from CVC4 to deps folder in Marabou project. Adds all the CD data structures from CVC4, of immediate interest are Context, CDList and CDO.
Fix compilation of added source files on Windows ( variadic syntax, /deps/base/check.h used some g++ specific pre-processor instructions). Noteworthy for the future, if we ever update CD files with new versions from CVC4 (due to bug fixes, updates, etc).