Add simulation for preprocess. #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tagomaru <tagomaru@users.noreply.github.com>
Signed-off-by: tagomaru <tagomaru@users.noreply.github.com>
Signed-off-by: tagomaru <tagomaru@users.noreply.github.com>
Signed-off-by: tagomaru <tagomaru@users.noreply.github.com>
Signed-off-by: tagomaru <tagomaru@users.noreply.github.com>
wu-haoze
reviewed
Mar 5, 2021
wu-haoze
reviewed
Mar 5, 2021
wu-haoze
requested changes
Mar 5, 2021
Signed-off-by: tagomaru <tagomaru@users.noreply.github.com>
Signed-off-by: tagomaru <tagomaru@users.noreply.github.com>
Signed-off-by: tagomaru <tagomaru@users.noreply.github.com>
wu-haoze
approved these changes
Mar 12, 2021
wu-haoze
reviewed
Mar 12, 2021
src/nlr/LayerOwner.h
Outdated
| @@ -32,6 +35,7 @@ class LayerOwner | |||
| virtual const ITableau *getTableau() const = 0; | |||
| virtual unsigned getNumberOfLayers() const = 0; | |||
| virtual void receiveTighterBound( Tightening tightening ) = 0; | |||
| virtual void simulate( Vector<Vector<double>> *input ) = 0; | |||
There was a problem hiding this comment.
Since simulate() is now called only in Engine.cpp, which stores nlr as a NetworkLevelReasoner instead of a LayerOwner, we probably don't need to add this method in the LayerOwner class.
wu-haoze
reviewed
Mar 12, 2021
src/nlr/LayerOwner.h
Outdated
| @@ -17,6 +17,9 @@ | |||
| #define __LayerOwner_h__ | |||
|
|
|||
| #include "Tightening.h" | |||
| #include "Vector.h" | |||
|
|
|||
| // #include <vector> | |||
src/configuration/Options.cpp
Outdated
| @@ -58,6 +58,7 @@ void Options::initializeDefaultValues() | |||
| _intOptions[VERBOSITY] = 2; | |||
| _intOptions[TIMEOUT] = 0; | |||
| _intOptions[CONSTRAINT_VIOLATION_THRESHOLD] = 20; | |||
| _intOptions[NUMBER_OF_SIMULATIONS] = 10; | |||
There was a problem hiding this comment.
Maybe set this to 1 for now? We can submit another PR after evaluating what is the best number of simulations.
Signed-off-by: tagomaru <tagomaru@users.noreply.github.com>
wu-haoze
approved these changes
Mar 16, 2021
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Add simulation for preprocess Signed-off-by: tagomaru <tagomaru@users.noreply.github.com> * fix compile error Signed-off-by: tagomaru <tagomaru@users.noreply.github.com> * small change Signed-off-by: tagomaru <tagomaru@users.noreply.github.com> * small change 2 Signed-off-by: tagomaru <tagomaru@users.noreply.github.com> * change ci Signed-off-by: tagomaru <tagomaru@users.noreply.github.com> * std::vector to Vector, and etc Signed-off-by: tagomaru <tagomaru@users.noreply.github.com> * change log Signed-off-by: tagomaru <tagomaru@users.noreply.github.com> * Fix system test apart from AbsoluteValue Signed-off-by: tagomaru <tagomaru@users.noreply.github.com> * fix minor issues Signed-off-by: tagomaru <tagomaru@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is going to add simulation function to enhance preprocess.