Maxconstraint fixes #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShantanuThakoor
requested review from
sparth95,
clazarus and
guykatzz
and removed request for
clazarus
|
Looks good, but can you please add unit tests to catch the errors you fixed? To prevent us from reintroducing them later. |
|
I added some tests, things do seem to work correctly now. |
fixed another minor bug cosmetics
guykatzz
added a commit
to guyam2/Marabou
that referenced
this pull request
Aug 20, 2020
…ification/master Merge from master
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* Fix for entailed tightenings * Subtle bug in removing variables * Bug fix for network containing 0 relus * Test for deleting maxpool elements appropriately * unit test to catch the bug that was fixed fixed another minor bug cosmetics * cosmetics * more cosmetics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight bug fixes; eliminate variables from elements only when certain that a different variable from within the element set has a lower bound strictly greater than them.