Handle MalformedBasis exceptions when adding a new equation #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Compute from left to write instead of from right to left. This makes multipliciation by eta matrices easier 2. Compute invLP once-and-for-all, when the basis is factorized
factorization classes to query the tableau for constraint matrix columns
basis factorization classes
…initializeTableau(0
tableau again and again every time
the tableau dimensions have changed. Tableau handles the case where the basis factorization fails after a row is added, by choosing a new set of basic variables using gaussian elimination of the constraint matrix
matanost
pushed a commit
that referenced
this pull request
Nov 2, 2021
* a more efficient computation of the explicit basis: 1. Compute from left to write instead of from right to left. This makes multipliciation by eta matrices easier 2. Compute invLP once-and-for-all, when the basis is factorized * pivoting stats * bug fix in store/restore * supprt for a "basis column oracle", which allows the basis factorization classes to query the tableau for constraint matrix columns * cleanup in FT factorization * grab a fresh basis from the oracle instead of condensing th etas * bug fix in test * started separating out the gaussian elimination functionality from the basis factorization classes * error when adding an equation * handle the initial assignment of basic variables as part of Tableau::initializeTableau(0 * make RowBoundTightener remember the tableau, instead of passing the tableau again and again every time * Tableau's addRow() informs objects registered as "resizeWatchers" that the tableau dimensions have changed. Tableau handles the case where the basis factorization fails after a row is added, by choosing a new set of basic variables using gaussian elimination of the constraint matrix * oops * oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.