-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SoIManager class #505
Merged
wu-haoze
merged 69 commits into
NeuralNetworkVerification:master
from
wu-haoze:heuristic-cost-manager
Feb 1, 2022
Merged
Add SoIManager class #505
wu-haoze
merged 69 commits into
NeuralNetworkVerification:master
from
wu-haoze:heuristic-cost-manager
Feb 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved computeHeuristicCost from Engine to CostFunctionManager
…/Marabou into marabou-soi-cont
wu-haoze
commented
Jan 25, 2022
guykatzz
approved these changes
Feb 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks really great. Well done. I read it thoroughly and only had trivial comments.
omriisack
pushed a commit
to omriisack/Marabou
that referenced
this pull request
Feb 6, 2022
* change tableau for optimization * optimize a cost function * minor * Cost function manager unit test * Add unit test * make optimization code public * fix numerical issue * add unit tests for tableau * Changed {is/not}Optimizing to toggleOptimization. Moved computeHeuristicCost from Engine to CostFunctionManager * extend relu constraints with soi * add unit test * Update PiecewiseLinearConstraint.h * change add/removeCostTerm to getCostTerm * add SoI for Max * add linear expression struct * add two more unit tests * change from HeuristicCost to LinearExpression * make linear expression a class * minor * soi manager * minor * minor * progress * add cpp and test * progress * get soi phase pattern * change initializer * progress * add test * concretize input assignment * progress * get phase status in assignment * passed unit test! * SoI manager * add another unit test * progress * progress in soi manager * add more tests * walksat * documentation * rename * sum of infeasibilities manager * Update Engine.h * Update Test_LinearExpression.h * Update Options.h * Update PiecewiseLinearConstraint.h * Update NetworkLevelReasoner.cpp * minor * Update MarabouCore.cpp * Update SoIInitializationStrategy.h * Update SoIInitializationStrategy.h * Update SoISearchStrategy.h * Update SumOfInfeasibilitiesManager.cpp * Update GlobalConfiguration.cpp * minor * clean up a bit * remove print statement * minor * update statistics * Update ReluConstraint.cpp * Update MaxConstraint.cpp * Update SumOfInfeasibilitiesManager.h * rename reduced cost to cost reduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new class SumOfInfeasibilitiesManager which maintains the current SoI phase pattern to guide the search, proposes updates to the SoI phase pattern, and decides whether to accept the proposal.