Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce memory usage #548

Merged
merged 7 commits into from
Mar 15, 2022
Merged

Conversation

wu-haoze
Copy link
Collaborator

@wu-haoze wu-haoze commented Mar 8, 2022

Reduce the number of input query and tableau state copy.
Also correct the behavior of the no-parallel-deepsoi option. Now this mode is run by default, and will be turned off by the flag.

@wu-haoze wu-haoze requested a review from guykatzz March 8, 2022 22:00
@@ -48,7 +48,7 @@ void Options::initializeDefaultValues()
_boolOptions[DUMP_BOUNDS] = false;
_boolOptions[SOLVE_WITH_MILP] = false;
_boolOptions[PERFORM_LP_TIGHTENING_AFTER_SPLIT] = false;
_boolOptions[PARALLEL_DEEPSOI] = true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "positive" flags are easier to understand than negative ones, due to double negations. Why was it bothering you the way it was before?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow boost option only seems to be able to set the flag to true. I played with it but didn't get it to work the other way..

@wu-haoze wu-haoze force-pushed the memory branch 3 times, most recently from 7241935 to fa4aaed Compare March 15, 2022 18:37
@wu-haoze wu-haoze merged commit 99c64b4 into NeuralNetworkVerification:master Mar 15, 2022
@wu-haoze wu-haoze deleted the memory branch March 15, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants