Add Statistic tracking for Context push/pop operations #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-haoze
reviewed
Sep 15, 2022
| @@ -391,6 +397,53 @@ void Statistics::print() | |||
| , totalTimeGettingSoIPhasePatternMicro | |||
| , printPercents( totalTimeGettingSoIPhasePatternMicro, | |||
| timeMainLoopMicro ) ); | |||
|
|
|||
| printf( "\t--- Context dependent statistics ---\n" ); | |||
There was a problem hiding this comment.
We printed NUM_POPS and NUM_SPLITS above. How are NUM_CONTEXT_PUSHES/POPS different from those? (Do we want to print these statistics together?)
There was a problem hiding this comment.
The semantics actually differ, since push and pop above are the old SmtCore implementation. I printed them here, since these are actual context operations and they can be used to gauge the average cost of a push/pop operation. In the new SmtCore the two semantics will actually match and I would still want the statistics shown in both places. Maybe even introduce average calculation or something.
wu-haoze
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic statistic tracking of number of context push/pop operations, as well as time breakdown between the push/pop and related hook calls.