Do not include cpuid.h on Apple ARM64. #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-haoze
approved these changes
Oct 28, 2022
nhamlv-55
pushed a commit
to nhamlv-55/Marabou
that referenced
this pull request
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #593.
On Apple M1 machines, building Marabou fails because
cpuid.hdoes not support the ARM64 architecture.Simply not including
cpuid.hon ARM64 architectures allows for the build to succeed.The
getCPUIdmacro definition then falls back to always yield"#"which should be fine, as the only place wheregetCPUIdseems to be used isDnCManager.cppfor logging purposes (which in turn does nothing in non-DEBUG builds).