Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug in disjunction constraint #603

Merged
merged 2 commits into from
Nov 14, 2022
Merged

fix bug in disjunction constraint #603

merged 2 commits into from
Nov 14, 2022

Conversation

wu-haoze
Copy link
Collaborator

  1. Condition for constraint being obsolete was incorrect in DisjunctionConstraint => for now DisjunctionConstraint is never obsolete
  2. nlr was constructed even when there is no input variables => don't construct nlr in this case

@wu-haoze wu-haoze requested a review from guykatzz November 13, 2022 21:56
@wu-haoze wu-haoze added the bug label Nov 13, 2022
@wu-haoze wu-haoze linked an issue Nov 13, 2022 that may be closed by this pull request
Bug: x = 0 gives error however x <= 0 returns SAT #602
Closed
@guykatzz guykatzz merged commit 2598362 into NeuralNetworkVerification:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guykatzz guykatzz guykatzz approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: x = 0 gives error however x <= 0 returns SAT
2 participants
@wu-haoze @guykatzz