Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof production code #613

Merged
merged 109 commits into from
Jan 24, 2023
Merged

Conversation

OmriIsacHUJI
Copy link
Contributor

No description provided.

Copy link
Collaborator

@guykatzz guykatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looking good - most of my comments are cosmetic.

src/engine/BoundManager.cpp Show resolved Hide resolved
src/engine/BoundManager.cpp Outdated Show resolved Hide resolved
src/engine/BoundManager.cpp Outdated Show resolved Hide resolved
src/engine/BoundManager.cpp Outdated Show resolved Hide resolved
src/engine/BoundManager.cpp Outdated Show resolved Hide resolved
src/engine/ReluConstraint.cpp Show resolved Hide resolved
src/engine/ReluConstraint.cpp Outdated Show resolved Hide resolved
src/engine/RowBoundTightener.cpp Outdated Show resolved Hide resolved
src/engine/RowBoundTightener.h Outdated Show resolved Hide resolved
src/engine/tests/MockBoundManager.h Show resolved Hide resolved
Copy link
Collaborator

@guykatzz guykatzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly cosmetic comments. Once they're resolved and the tests pass, you can go ahead and merge.

src/engine/Engine.cpp Show resolved Hide resolved
src/engine/Engine.cpp Outdated Show resolved Hide resolved
src/engine/Engine.cpp Show resolved Hide resolved
src/engine/Engine.cpp Outdated Show resolved Hide resolved
src/engine/Engine.cpp Outdated Show resolved Hide resolved
src/engine/ICostFunctionManager.h Outdated Show resolved Hide resolved
src/engine/IEngine.h Outdated Show resolved Hide resolved
src/engine/PrecisionRestorer.cpp Show resolved Hide resolved
src/engine/SmtCore.cpp Outdated Show resolved Hide resolved
src/engine/tests/MockEngine.h Show resolved Hide resolved
@omriisack omriisack changed the title Update BoundManager, ReluConstraint and RowBoundTightener with proof production code Proof production code Jan 24, 2023
@omriisack omriisack marked this pull request as ready for review January 24, 2023 10:54
@omriisack omriisack merged commit 663835d into NeuralNetworkVerification:master Jan 24, 2023
OmriIsacHUJI added a commit to OmriIsacHUJI/Marabou that referenced this pull request Jan 31, 2023
wu-haoze pushed a commit that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants