Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower TensorFlow version bound #648

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Lower TensorFlow version bound #648

merged 4 commits into from
Jul 12, 2023

Conversation

wenkokke
Copy link
Collaborator

This PR lowers the version bound for TensorFlow, because the maraboupy tests fail for version 2.13.

See this failing test:

  # Simplify graph using outputNames, which must be specified for SavedModel
> simp_graph_def = graph_util.convert_variables_to_constants(sess,sess.graph.as_graph_def(),outputNames)
E AttributeError: module 'tensorflow.python.framework.graph_util' has no attribute 'convert_variables_to_constants'

MatthewDaggitt
MatthewDaggitt approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@MatthewDaggitt MatthewDaggitt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @anwu1219 I've approved this, as it's only an minor administrative change and I don't think it needs your attention. Let me know if you'd prefer me not to in future.

@wenkokke wenkokke merged commit 25874d8 into NeuralNetworkVerification:master Jul 12, 2023
@wenkokke wenkokke deleted the fix-maraboupy branch July 12, 2023 18:24
wu-haoze pushed a commit that referenced this pull request Mar 4, 2024
@wenkokke @wu-haoze
Lower TensorFlow version bound (#648)
20af273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewDaggitt MatthewDaggitt MatthewDaggitt approved these changes

Assignees
No one assigned
Labels
project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenkokke @MatthewDaggitt