-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maraboupy #9
maraboupy #9
Conversation
-implemented method that adds the Relu constraints given two variables -avoids exposing PiecewiseLinearConstraint to the shared library
-Abstrac classes needed for maraboupy -TF Parser -NNet Parser -Example scripts -Example Notebooks -Example TF network proto buffers.
-fixed comments indentation -updated .gitignore
Changed MarabouCore.cpp to add addReluConstraint function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
maraboupy/Rules.mk
Outdated
@@ -0,0 +1,178 @@ | |||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment from before, otherwise the PR looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rules.mk has been removed from /maraboupy and we now use the one in the root directory. We have modified the Makefile in /maraboupy accordingly. I believe this file was there in a previous commit. Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as well.
Introducing maraboupy: a python module that wraps Marabou and enables easy interaction with Tensorflow networks and .nnet files. * Python Wrapper -Abstract classes needed for maraboupy -TF Parser -NNet Parser -Example scripts -Example Notebooks -Example TF network proto buffers. * Refactored addReluConstraint into MarabouCore * Left all original Marabou code untouched and moved all needed modifications to maraboucore.cpp in maraboupy. * Maraboupy now uses the same Rules.mk as Marabou and uses its own Makefile for its flags.
maraboupy python module.
Parsers for: