Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support single op used as input by multiple ops; implement var+var op #95

Merged
merged 4 commits into from
Oct 2, 2018
Merged

Support single op used as input by multiple ops; implement var+var op #95

merged 4 commits into from
Oct 2, 2018

Conversation

ShantanuThakoor
Copy link
Collaborator

@ShantanuThakoor ShantanuThakoor commented Oct 1, 2018 •
edited
Loading

  1. Earlier, if we had something like
    x1 = input+1; x2 = input + 2; x3 = x1 + x2

we would get an error, there was an implicit assumption that network is a tree and not a DAG. Fixed this.

  1. Implemented a way to see whether a given op represents something dependent on input (i.e., is a variable) or independent (i.e., is a constant). Based on this, implemented appropriate add and biasAdd functions.

clazarus
clazarus approved these changes Oct 2, 2018
View reviewed changes
Copy link
Collaborator

@clazarus clazarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sparth95 sparth95 self-requested a review October 2, 2018 02:07
@sparth95
Copy link
Collaborator

sparth95 commented Oct 2, 2018

LGTM

@ShantanuThakoor ShantanuThakoor merged commit d4e3fdb into NeuralNetworkVerification:master Oct 2, 2018
@ShantanuThakoor ShantanuThakoor deleted the add-fix branch October 2, 2018 04:12
matanost pushed a commit that referenced this pull request Nov 2, 2021
@ShantanuThakoor
Support single op used as input by multiple ops; implement var+var op (…
0b0c927 
…#95)

* Support single op used as input by multiple ops; implement var+var op
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sparth95 sparth95 sparth95 approved these changes

@clazarus clazarus clazarus approved these changes

@chelseas chelseas Awaiting requested review from chelseas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShantanuThakoor @sparth95 @clazarus