check if search query actually returns an item #13

kennnyshiwa · 2020-04-25T23:58:28Z

I forgot that with the search endpoint you don't get a 404 only a count of 0 if the search doesn't exist this handles that

NeuroAssassin

Two quick things then it should be good to be merged.

"Invalid ID" string, as said below
Lines 318 and 390 should be unindented so that they aren't under the ctx.typing, but that may be my fault.

NeuroAssassin · 2020-05-05T11:41:30Z

sw/sw.py

@@ -113,6 +113,8 @@ async def person(self, ctx, person_id: Union[int,str]):
                if response.status == 404:
                    return await ctx.send("Invalid Person ID.")


Since this is a string/query and not an ID per se, could this and the other ones in the string queries be converted to just "Invalid person/film/etc"?

check if search query actually returns an item

7259b2a

I forgot that with the search endpoint you don't get a 404 only a count of 0 if the search doesn't exist this handles that

NeuroAssassin requested changes May 5, 2020

View reviewed changes

NeuroAssassin self-assigned this May 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

check if search query actually returns an item #13

check if search query actually returns an item #13

kennnyshiwa commented Apr 25, 2020

NeuroAssassin left a comment

NeuroAssassin May 5, 2020

		@@ -113,6 +113,8 @@ async def person(self, ctx, person_id: Union[int,str]):
		if response.status == 404:
		return await ctx.send("Invalid Person ID.")

check if search query actually returns an item #13

Are you sure you want to change the base?

check if search query actually returns an item #13

Conversation

kennnyshiwa commented Apr 25, 2020

NeuroAssassin left a comment

Choose a reason for hiding this comment

NeuroAssassin May 5, 2020

Choose a reason for hiding this comment