Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for NMLv2.3 #93

Merged
merged 29 commits into from
Sep 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
c45ba7b
Add ci
pgleeson Nov 10, 2021
018f177
Improved ci.yml
pgleeson Nov 10, 2021
f8acda6
Improved getneuroml
pgleeson Nov 16, 2021
5b0b179
Merge pull request #84 from NeuroML/osb_test
pgleeson Nov 16, 2021
9938d85
Scope of log4j should be compile/run
pgleeson Apr 8, 2022
1e9e281
Initial EDEN export
pgleeson Apr 26, 2022
209db6a
Add eden to tests
pgleeson Apr 26, 2022
94bd373
To v0.12.0 here, v1.9.0 in others for NeuroML v2.3
pgleeson May 12, 2022
bb86b2e
Update options for netpyne json export
pgleeson Jun 29, 2022
292391a
Merge branch 'master' into development
pgleeson Aug 5, 2022
b7af3ff
Merge branch 'development' into experimental
pgleeson Aug 8, 2022
28a04a6
Merge pull request #88 from NeuroML/experimental
pgleeson Oct 13, 2022
23b6345
To v0.12.1
pgleeson Dec 6, 2022
f2aecbe
Merge pull request #89 from NeuroML/experimental
pgleeson Dec 6, 2022
9b09caa
Test on java 19
Feb 23, 2023
be56af1
Merge pull request #90 from NeuroML/experimental
pgleeson Feb 23, 2023
f5bccd6
Update ci.yml
pgleeson Apr 3, 2023
af7136d
Merge branch 'master' into development
pgleeson May 3, 2023
ff843f8
Test on win 2019
pgleeson May 3, 2023
a070aef
Merge pull request #92 from NeuroML/experimental
pgleeson May 3, 2023
5d15bc1
Merge branch 'master' into experimental
pgleeson May 4, 2023
059e933
Merge branch 'experimental' into development
pgleeson May 4, 2023
565f7c5
Remove travis ci file
pgleeson May 9, 2023
9098898
Update to jnml v0.12.2
pgleeson May 9, 2023
a754d1b
More unifoirmity in listing of generated files by jNeuroML
pgleeson Aug 1, 2023
1f3d0a2
Update to jnml v0.12.3
pgleeson Sep 12, 2023
5990ea5
Merge pull request #95 from NeuroML/experimental
pgleeson Sep 12, 2023
7063e86
To v0.12.4
pgleeson Sep 20, 2023
5801d66
Merge pull request #96 from NeuroML/experimental
pgleeson Sep 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [ '8', '11', '16', '17' ]
runs-on: [ubuntu-latest, macos-11, windows-2019 ]
java: [ '8', '11', '16', '17', '19']
runs-on: [ubuntu-latest, macos-latest, windows-2019 ]

name: Test on Java ${{ matrix.Java }} on ${{ matrix.runs-on }}
steps:
Expand Down Expand Up @@ -68,10 +68,12 @@ jobs:
./jnml ../NeuroML2/LEMSexamples/LEMS_NML2_Ex9_FN.xml -cvode
./jnml ../NeuroML2/LEMSexamples/LEMS_NML2_Ex9_FN.xml -matlab
./jnml ../NeuroML2/LEMSexamples/LEMS_NML2_Ex9_FN.xml -dlems
./jnml ../NeuroML2/LEMSexamples/LEMS_NML2_Ex9_FN.xml -eden
./jnml ../NeuroML2/LEMSexamples/regression-tests/LEMS_NML2_Ex5_DetCell_unformatted.xml -nogui
./jnml ../NeuroML2/examples/NML2_SimpleMorphology.nml -svg
ls -alt ../NeuroML2/examples
ls -alt ../NeuroML2/LEMSexamples
env

- name: Further tests (Win)
if: ${{ matrix.runs-on == 'windows-2019' }}
Expand All @@ -87,5 +89,6 @@ jobs:
.\jnml.bat ..\NeuroML2\LEMSexamples\LEMS_NML2_Ex9_FN.xml -cvode
.\jnml.bat ..\NeuroML2\LEMSexamples\LEMS_NML2_Ex9_FN.xml -matlab
.\jnml.bat ..\NeuroML2\LEMSexamples\LEMS_NML2_Ex9_FN.xml -dlems
.\jnml.bat ..\NeuroML2\LEMSexamples\LEMS_NML2_Ex9_FN.xml -eden
.\jnml.bat ..\NeuroML2\LEMSexamples\regression-tests\LEMS_NML2_Ex5_DetCell_unformatted.xml -nogui
.\jnml.bat ..\NeuroML2\examples\NML2_SimpleMorphology.nml -svg
58 changes: 0 additions & 58 deletions .travis.yml

This file was deleted.

6 changes: 4 additions & 2 deletions getNeuroML.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ def main():
or ("jNeuroML" in repo)
)

if (repo in java_repos or repo in neuroml2_spec_repo) and runMvnInstall:
if (repo in java_repos or repo in neuroml2_spec_repo) \
and runMvnInstall:
command = "mvn install"
print("It's a Java repository, so installing using Maven...")
info = execute_command_in_dir(command, local_dir)
Expand Down Expand Up @@ -162,7 +163,8 @@ def execute_command_in_dir(command, directory, exit_on_fail=True):
% (command, directory, os.path.abspath(directory))
)

p = subprocess.Popen(command, cwd=directory, shell=True, stdout=subprocess.PIPE)
p = subprocess.Popen(command, cwd=directory, shell=True,
stdout=subprocess.PIPE)
return_str = p.communicate()

if p.returncode != 0:
Expand Down
2 changes: 1 addition & 1 deletion jnml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# Type java -X for more info
export JNML_MAX_MEMORY=400M

export JNML_VERSION=0.11.1
export JNML_VERSION=0.12.4


export CLASSPATH=.:./target/jNeuroML-$JNML_VERSION-jar-with-dependencies.jar:$JNML_HOME/target/jNeuroML-$JNML_VERSION-jar-with-dependencies.jar
Expand Down
2 changes: 1 addition & 1 deletion jnml.bat
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@echo off

set JNML_VERSION=0.11.1
set JNML_VERSION=0.12.4

set CLASSPATH=target\jNeuroML-%JNML_VERSION%-jar-with-dependencies.jar;%JNML_HOME%\jNeuroML-%JNML_VERSION%-jar-with-dependencies.jar

Expand Down
10 changes: 4 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

<groupId>org.neuroml</groupId>
<artifactId>jNeuroML</artifactId>
<version>0.11.1</version>
<version>0.12.4</version>
<packaging>jar</packaging>

<name>jNeuroML</name>
Expand All @@ -24,26 +24,24 @@
<dependency>
<groupId>org.neuroml1.model</groupId>
<artifactId>org.neuroml1.model</artifactId>
<version>1.8.1</version>
<version>1.9.1</version>
</dependency>
<dependency>
<groupId>org.neuroml.import</groupId>
<artifactId>org.neuroml.import</artifactId>
<version>1.8.1</version>
<version>1.9.1</version>
</dependency>

<!-- Dependencies to force use of log4j 2.17.1 -->
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-1.2-api</artifactId>
<version>2.17.1</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
<version>2.17.1</version>
<scope>test</scope>
</dependency>


Expand All @@ -61,7 +59,7 @@
&lt;br /&gt;
&lt;br /&gt;
</top>
<bottom>Copyright NeuroML Contributors 2021</bottom>
<bottom>Copyright NeuroML Contributors 2023</bottom>
</configuration>
</plugin>
<plugin>
Expand Down
Loading
Loading