Feat: extend morphology plotting methods to accept a file path and objects; move vispy bits to separate module to reduce import errors (breaking) #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. so that we don't have to write cells to files just to plot them.
sanjayankur31
added
T: enhancement
This ensures that there are no import errors if the optional vispy package is not installed. BREAKING CHANGE: vispy functions have moved out from PlotMorphology to PlotMorphologyVispy
sanjayankur31
changed the title
|
breaking since moving the vispy routines technically breaks API. I'm wondering if the helper methods should also be made private to prevent users from using these. They should only be using the high level |
so that default usage does not require plotly BREAKING CHANGE: plotly methods are now in pyneuroml.plot.PlotMorphologyPlotly
to ensure we get morphology plots even when cells are merely included
…also-take-nmldocs
if it's a network file, use the network id; otherwise use the cell id.
[skip ci]
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.