Debug DANDI upload argument defaults #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodyCBakerPhD
commented
Aug 31, 2024
| @@ -1277,7 +1277,9 @@ def upload_multiple_filesystem_objects_to_dandi(**kwargs) -> list[Path]: | |||
| del innerKwargs["filesystem_paths"] | |||
| innerKwargs["nwb_folder_path"] = tmp_folder_path | |||
| results = upload_folder_to_dandi(**innerKwargs) | |||
| rmtree(tmp_folder_path) | |||
|
|
|||
| rmtree(tmp_folder_path, ignore_errors=True) | |||
There was a problem hiding this comment.
Also fixed this, which can happen if you enable 'cleanup' option but cleanup succeeds in earlier stage (earlier stage is known to fail stochastically on certain platforms, which is why we try it again here)
Closed
bendichter
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #922
Not sure when or how this changed
I tried it out with
v1.0.0of the GUIDE and this issue did not exist at that timeBut in latest release, the values being sent back from the frontend were
null(even if they visually displayed as the default values of1), causingnumber_of_jobsto set toNonefrom the top level of all Python argument passing, which for parallelization usually means 'use all jobs'So I was able to replicate the issue locally and then tested that this fix resolves the issue on a local build
@rly and I discussed having a pre-release TODO checklist (including RTD switcher bumps) - this would be a good thing to add to that list