Pin mac runners to x64 #450
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,14 +8,14 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| os: ["ubuntu-latest", "macos-13", "windows-latest"] | ||
| python-version: ["3.8", "3.9", "3.10", "3.11"] | ||
|
There was a problem hiding this comment. Action runners are easy to come by nowadays, and our suite is so light that I think it's fine to test against all versions |
||
| steps: | ||
| - uses: conda-incubator/setup-miniconda@v3 | ||
|
There was a problem hiding this comment.
|
||
| with: | ||
| auto-update-conda: true | ||
| python-version: ${{ matrix.python-version }} | ||
| channels: conda-forge | ||
| - uses: actions/checkout@v3 | ||
| - run: git fetch --prune --unshallow --tags | ||
|
|
||
|
|
@@ -26,12 +26,12 @@ jobs: | |
|
|
||
| - name: Install package | ||
| run: | | ||
| pip install . | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. When was There was a problem hiding this comment. Not sure - originally heard this from @h-mayorquin when we updated NeuroConv similarly It's thrown a deprecation warning in console for a long time - this was the first time when trying it lead to an actual error in CI though But reading into https://packaging.python.org/en/latest/discussions/setup-py-deprecated/ it seems it's not the method itself that's deprecated but rather the route through the CLI - so maybe that could still work However, I'd rather swap the more official There was a problem hiding this comment. Oh I see. There was a problem hiding this comment. Editable mode is a setuptools feature that might not be availabe in other installation backends (e.g. poetry). pip just relies to the instructions to the backend: https://pip.pypa.io/en/stable/topics/local-project-installs/#editable-installs But I think most backends implement this. Now, the real problematic part is that editable mode in setuptools changed dramatically on recent versions: https://setuptools.pypa.io/en/latest/userguide/development_mode.html My suggestion was that we should not use that API in the CI because it is unstable (within setuptools versions and across build backends implementations) and I suspected it was generating an error (I don't remember if I was right). This is in line what what setuptools suggest themselves (see the attention section in top of limitations here): There was a problem hiding this comment. Interesting. Thanks for the additional information @h-mayorquin ! In the pynwb/hdmf stack, we use |
||
| pip install dandi | ||
| - name: Download testing data and set config path | ||
| run: | | ||
| dandi download "https://gui-staging.dandiarchive.org/#/dandiset/204919" | ||
| python -c "from nwbinspector.testing import update_testing_config; update_testing_config(key='LOCAL_PATH', value='{nwbinspector.__file__}/204919/testing_files/')" | ||
|
There was a problem hiding this comment. Another consequence of not using |
||
| - name: Uninstall h5py | ||
| run: pip uninstall -y h5py | ||
| - name: Install ROS3 | ||
|
|
@@ -43,7 +43,7 @@ jobs: | |
|
|
||
| - name: Run pytest with coverage | ||
| run: | | ||
| pytest -rsx --cov=nwbinspector --cov-report xml:./nwbinspector/nwbinspector/coverage.xml | ||
|
There was a problem hiding this comment. Need to adjust name here to track coverage (used to rely on |
||
| pytest tests/ -rsx tests/read_nwbfile_tests.py # TODO when read_nwbfile is ported | ||
| - if: ${{ matrix.python-version == '3.10' && matrix.os == 'ubuntu-latest' }} | ||
| name: Upload coverage to Codecov | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub also started allowing relative paths to these sometime in the last year - making it a lot more convenient