Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide strtobool to avoid use of deprecated (removed in 3.12) distutils #457

Merged

Conversation

yarikoptic
Copy link
Contributor

@yarikoptic yarikoptic commented May 3, 2024

Motivation

Makes incompatible with 3.12

TODO

  • add testing for 3.12

@yarikoptic
Copy link
Contributor Author

  • please advise on how to update CHANGELOG or feel welcome to update on my behalf
  • quick review/merge/release would be appreciated since needed to bring dandi-cli into green on CI again.

@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) May 3, 2024 14:08
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.85%. Comparing base (2e42e34) to head (67625df).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #457      +/-   ##
==========================================
+ Coverage   86.78%   86.85%   +0.07%     
==========================================
  Files          23       23              
  Lines        1241     1248       +7     
==========================================
+ Hits         1077     1084       +7     
  Misses        164      164              
Flag Coverage Δ
unittests 86.85% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/nwbinspector/nwbinspector.py 84.71% <ø> (-0.07%) ⬇️
src/nwbinspector/testing.py 83.63% <100.00%> (-0.30%) ⬇️
src/nwbinspector/utils.py 88.33% <100.00%> (+0.94%) ⬆️

@CodyCBakerPhD CodyCBakerPhD merged commit 045ba56 into NeurodataWithoutBorders:dev May 3, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants