Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove robust_ros3_retry #506

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Remove robust_ros3_retry #506

merged 5 commits into from
Sep 6, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

Removed the ROS3 retry helper since it is no longer needed

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review September 6, 2024 15:58
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

CHANGELOG.md Outdated Show resolved Hide resolved
src/nwbinspector/_nwb_inspection.py Show resolved Hide resolved
Co-authored-by: Steph Prince <40640337+stephprince@users.noreply.github.com>
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) September 6, 2024 17:52
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.98%. Comparing base (27e4d25) to head (678374d).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
src/nwbinspector/_nwb_inspection.py 77.27% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #506      +/-   ##
==========================================
+ Coverage   79.33%   84.98%   +5.64%     
==========================================
  Files          48       48              
  Lines        1423     1412      -11     
==========================================
+ Hits         1129     1200      +71     
+ Misses        294      212      -82     
Files with missing lines Coverage Δ
src/nwbinspector/utils/__init__.py 100.00% <ø> (ø)
src/nwbinspector/utils/_utils.py 91.89% <100.00%> (+3.27%) ⬆️
src/nwbinspector/_nwb_inspection.py 83.82% <77.27%> (+4.56%) ⬆️

... and 4 files with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD merged commit c7861f4 into dev Sep 6, 2024
45 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the purge_ros3_retry branch September 6, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants