Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support only latest PyNWB #510

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Support only latest PyNWB #510

merged 7 commits into from
Sep 17, 2024

Conversation

CodyCBakerPhD
Copy link
Collaborator

As per previous discussion about what range of support NWB Inspector ought to have with past PyNWB/HDMF versions - we decided it should only support latest

This simplifies a lot of conditions on the core inspection logic, individual checks, and what the testing suite is responsible for checking

The only aspect that cannot be replaced is using old versions of PyNWB to generate example files with particular failures that are no longer possible to achieve in latest PyNWB - these are still good to check the inspection logic on since someone could write a file using an older version but inspect it in a different environment (DANDI validate/upload would outright require that) - so I'm keeping those helpers around

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 6, 2024
@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review September 6, 2024 19:41
@CodyCBakerPhD
Copy link
Collaborator Author

TODO in follow-up: re-implement #265

@CodyCBakerPhD CodyCBakerPhD linked an issue Sep 6, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a couple comments/questions.

CHANGELOG.md Outdated Show resolved Hide resolved
src/nwbinspector/_nwb_inspection.py Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
Co-authored-by: Steph Prince <40640337+stephprince@users.noreply.github.com>
@CodyCBakerPhD CodyCBakerPhD enabled auto-merge (squash) September 17, 2024 00:53
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.03%. Comparing base (c7861f4) to head (050ddc5).
Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
src/nwbinspector/checks/_images.py 88.23% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #510      +/-   ##
==========================================
+ Coverage   79.53%   85.03%   +5.50%     
==========================================
  Files          48       48              
  Lines        1412     1390      -22     
==========================================
+ Hits         1123     1182      +59     
+ Misses        289      208      -81     
Files with missing lines Coverage Δ
src/nwbinspector/_dandi_inspection.py 98.03% <100.00%> (+76.88%) ⬆️
src/nwbinspector/_nwb_inspection.py 85.49% <100.00%> (+6.08%) ⬆️
src/nwbinspector/checks/_images.py 89.47% <88.23%> (-1.44%) ⬇️

... and 3 files with indirect coverage changes

@CodyCBakerPhD CodyCBakerPhD merged commit e3cc7e2 into dev Sep 17, 2024
38 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the support_only_modern_pynwb branch September 17, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Philosophy for interactions with PyNWB versions
3 participants