Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coverage call, don't install in editable mode in testing #1897

Merged
merged 3 commits into from
May 2, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 29, 2024

Motivation

Follow-up to NeurodataWithoutBorders/nwbinspector#450 (comment)

https://setuptools.pypa.io/en/latest/userguide/development_mode.html says

Editable installs are not a perfect replacement for regular installs in a test environment. When in doubt, please test your projects as installed via a regular wheel. There are tools in the Python ecosystem, like tox or nox, that can help you with that (when used with appropriate configuration).

We use editable installs in testing in a couple places, mostly to help coverage find the sources, but we can configure that in pyproject.toml instead.

How to test the behavior?

Run GitHub actions

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (376e6ab) to head (00f15b0).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1897   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          27       27           
  Lines        2619     2619           
  Branches      685      685           
=======================================
  Hits         2410     2410           
  Misses        139      139           
  Partials       70       70           
Flag Coverage Δ
integration 72.81% <ø> (ø)
unit 83.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly marked this pull request as ready for review April 29, 2024 22:42
@stephprince stephprince requested a review from mavaylon1 May 2, 2024 20:16
@mavaylon1 mavaylon1 merged commit 78ebc86 into dev May 2, 2024
23 checks passed
@mavaylon1 mavaylon1 deleted the no_editable branch May 2, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants