Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add undo/redo support #59

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Add undo/redo support #59

merged 2 commits into from
Mar 21, 2023

Conversation

Neverous
Copy link
Owner

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 20, 2023
View reviewed changes
src/efibootdata.cpp
{
emit progress(0, 1, tr("Exporting boot configuration..."));
QFile export_file(file_name);
if(!export_file.open(QIODevice::WriteOnly))

Check notice

Code scanning / Flawfinder (reported by Codacy)

Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362).

Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362).
src/efibootdata.cpp
{
emit progress(0, 1, tr("Exporting boot configuration..."));
QFile dump_file(file_name);
if(!dump_file.open(QIODevice::WriteOnly))

Check notice

Code scanning / Flawfinder (reported by Codacy)

Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362).

Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362).
src/efibootdata.cpp
{
emit progress(0, 1, tr("Importing boot configuration..."));
QFile import_file(file_name);
if(!import_file.open(QIODevice::ReadOnly))

Check notice

Code scanning / Flawfinder (reported by Codacy)

Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362).

Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362).
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 20, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cppcheck (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 20, 2023
View reviewed changes
include/disableundoredo.h
}

DisableUndoRedo(const DisableUndoRedo &) = delete;
DisableUndoRedo &operator=(const DisableUndoRedo &) = delete;

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 802 with no text in the supplied rule-texts-file

misra violation 802 with no text in the supplied rule-texts-file
include/disableundoredo.h
{
}

DisableUndoRedo(const DisableUndoRedo &) = delete;

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 806 with no text in the supplied rule-texts-file

misra violation 806 with no text in the supplied rule-texts-file
include/disableundoredo.h
}

DisableUndoRedo(const DisableUndoRedo &) = delete;
DisableUndoRedo &operator=(const DisableUndoRedo &) = delete;

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 806 with no text in the supplied rule-texts-file

misra violation 806 with no text in the supplied rule-texts-file
include/disableundoredo.h
{
}

DisableUndoRedo(const DisableUndoRedo &) = delete;

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 802 with no text in the supplied rule-texts-file

misra violation 802 with no text in the supplied rule-texts-file
include/disableundoredo.h
Q_OBJECT

public:
explicit DisableUndoRedo(QObject *parent = nullptr)

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 806 with no text in the supplied rule-texts-file

misra violation 806 with no text in the supplied rule-texts-file
@Neverous Neverous marked this pull request as ready for review March 20, 2023 23:43
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/build_test.yml:build-windows/compiler:Clang/os:windows-2019/qt_version:6.4.3. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/build_test.yml:build-macos/compiler:Clang/os:macos-11/qt_version:6.4.3. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/build_test.yml:build-windows/compiler:MSVC/os:windows-2019/qt_version:6.4.3. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/build_test.yml:build-macos/compiler:Clang/os:macos-12/qt_version:6.4.3. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/build_test.yml:build-linux/compiler:Clang/os:ubuntu-20.04/qt_version:6.4.3. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/build_test.yml:build-linux/compiler:Clang/os:ubuntu-22.04/qt_version:6.4.3. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/build_test.yml:build-linux/compiler:GCC/os:ubuntu-20.04/qt_version:6.4.3. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/build_test.yml:build-windows/compiler:Clang/os:windows-2022/qt_version:6.4.3. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/build_test.yml:build-linux/compiler:GCC/os:ubuntu-22.04/qt_version:6.4.3. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 21, 2023
View reviewed changes
include/disableundoredo.h
protected:
bool eventFilter(QObject *obj, QEvent *ev) override
{
if(ev->type() == QEvent::ShortcutOverride)

Check warning

Code scanning / PREfast

The enum type 'QEvent::Type' is unscoped. Prefer 'enum class' over 'enum' (Enum.3).

The enum type 'QEvent::Type' is unscoped. Prefer 'enum class' over 'enum' (Enum.3).
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/build_test.yml:build-windows/compiler:MSVC/os:windows-2022/qt_version:6.4.3. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@Neverous Neverous merged commit 5babe69 into master Mar 21, 2023
@Neverous Neverous deleted the undostack branch March 21, 2023 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Neverous