Skip to content
This repository has been archived by the owner on Dec 6, 2019. It is now read-only.

86-absolute-path-imports #88

Merged
merged 4 commits into from
Nov 8, 2017
Merged

86-absolute-path-imports #88

merged 4 commits into from
Nov 8, 2017

Conversation

Lepozepo
Copy link
Contributor

@Lepozepo Lepozepo commented Nov 7, 2017

Fixes #86

Creator

  • Build relevant tests if any apply
  • Ensure there are no new warnings
  • Upload an animated GIF showcasing the solution (if it applies)
  • Set a relevant reviewer

Reviewer

  • Run test and make sure all tests pass
  • Review function and form on iOS
  • Review function and form on Android
  • Review function and form on Web
  • Review new test logic

Web picks up on babel config so it's all good, no need to NODE_PATH this one
@Lepozepo Lepozepo added the ready for review PR is ready for review label Nov 7, 2017
@mary-pr-poppins
Copy link

mary-pr-poppins commented Nov 7, 2017

Warnings
⚠️

No Changelog changes!

Generated by 🚫 dangerJS

Copy link
Member

@burkeshartsis burkeshartsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can we update the rest of the apps imports to use absolute paths?

@Lepozepo
Copy link
Contributor Author

Lepozepo commented Nov 7, 2017

@burkeshartsis is this ready now?

@Lepozepo Lepozepo merged commit c45d10c into master Nov 8, 2017
@Lepozepo Lepozepo deleted the 86-absolute-path-imports branch November 8, 2017 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready for review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants