Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OFW PR 3822 (MIFARE Classic Key Recovery Improvements) #207

Merged
merged 84 commits into from
Sep 27, 2024
Merged

OFW PR 3822 (MIFARE Classic Key Recovery Improvements) #207

merged 84 commits into from
Sep 27, 2024

Conversation

Willy-JL
Copy link
Member

@Willy-JL Willy-JL commented Sep 3, 2024 •
edited
Loading

What's new

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

noproto and others added 30 commits August 1, 2024 09:10
@noproto
Initial structure for nonce collection
cf6d6bb
@noproto
Nonce logging
b154603
@noproto
Dictionary attack structure
ef16770
@noproto
Merge branch 'flipperdevices:dev' into nestednonces
d3bf372
@noproto
Fix compilation
213ec1d
@noproto
Identified method to reduce candidate states
9ba78bf
@noproto
Use EXT_PATH instead of ANY_PATH
6d66638
@noproto
Merge branch 'flipperdevices:dev' into nestednonces
e61b543
@noproto
Use median calibrated distance, collect parity bits
09f8a73
@noproto
Modify parity collection
7d2cab5
@noproto
Fixed parity bit collection
8dd3daf
@noproto
Add note to fix nonce logging
4b44288
@noproto
Fix nonce logging
5feeae8
@noproto
Clean redundant code
3acba77
@noproto
Fix valid_nonce
6332ec7
@noproto
First attempt disambiguous nonce implementation
01b1948
@noproto
Merge remote-tracking branch 'origin/dev' into nestednonces
8d1a220
@noproto
FM11RF08S backdoor detection
cc8cae7
@noproto
Initial accelerated dictionary attack for weak PRNGs
79bc887
@noproto
Refactor to nested dictionary attack
0af28fb
@noproto
Renaming some variables
08ca794
@noproto
Hard PRNG support for accelerated dictionary attack
b7e63bf
@noproto
Update found keys, initial attempt
bbc10cd
@noproto
Update found keys, second attempt
75a0e4b
@noproto
Code cleanup
c1f01ce
@noproto
Misc bugfixes
26845cb
@noproto
Only use dicts in search_dicts_for_nonce_key if we have them
5235592
@noproto
Collect nonces again
0b33c85
@noproto
Should be detecting both backdoors now
c0331ba
@noproto
Relocate backdoor detection
4c14594
@Willy-JL Willy-JL mentioned this pull request Sep 19, 2024
Merged
5 tasks
noproto and others added 18 commits September 20, 2024 11:53
@noproto
Zero nested_target_key and msb_count on exit
6eccdc8
@noproto
Note TODO (malloc)
c21b359
@noproto
Dismiss duplicate nonces
6a77ab7
@noproto
Fix calibration (ensure values are within 3 standard deviations)
901bdf9
@noproto
Log static
4eb0f2a
@noproto
No nested dictionary attack re-entry
6ae9506
@noproto
Note minor inefficiency
cd76926
@noproto
Uniformly use crypto1_ prefix for symbols in Crypto1 API
0ba8ac4
@noproto
Fix include paths
61e24fc
@Willy-JL
Merge remote-tracking branch 'mntm/dev' into ofw-3822-nestednonces
49fa88a
@Willy-JL
Merge branch 'nestednonces' into ofw-3822-nestednonces
ae3b2d4
@noproto
Fix include paths cont
099bb40
@noproto
Support CUID dictionary
ba672e7
@Willy-JL
Merge remote-tracking branch 'mntm/dev' into ofw-3822-nestednonces
3a4fece
@Willy-JL
Merge branch 'nestednonces' into ofw-3822-nestednonces
448be96
@Willy-JL
Checkout MFKey 3.0 apps branch
10f24d0
@Willy-JL
Update NFC Magic for OFW PR 3822 changes
7e2d1b8
@Willy-JL
Update changelog
7c98f74
@Willy-JL Willy-JL marked this pull request as ready for review September 27, 2024 02:44
@Willy-JL Willy-JL merged commit f8688d7 into dev Sep 27, 2024
5 checks passed
@Willy-JL Willy-JL deleted the ofw-3822-nestednonces branch September 27, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Willy-JL @noproto @skotopes @gornekich