MCS-1796 Fixed frame off-by-one error in webenabled UI #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ThomasSchellenbergNextCentury
commented
May 11, 2023
ThomasSchellenbergNextCentury
commented
- When performing an action, wait for the new image to become ready
- When selecting a scene, display the initial image
ThomasSchellenbergNextCentury
requested review from
rartiss55,
jaudick,
phile-caci and
NDCACI
|
@ThomasSchellenbergNextCentury The only way I can get this actually show an image after frame 0 is by holding down a button which forces it to be one frame behind. Then the images appear. So if I dont hold a button and input something every second or so then I can never see the image appear. Frame 0: Frame 1 after a second: Frame 20+ if i hold down movement buttons putting me a frame behind: |
|
@jaudick I'm assuming this happens fairly consistently? Maybe we should try a screen share tomorrow so I can see what you're talking about. Would you mind share the complete terminal logs? |
|
@ThomasSchellenbergNextCentury |
phile-caci
approved these changes
May 23, 2023
|
@jaudick @rartiss55 I've tested with Python 3.10 on Ubuntu (with the same versions of the python dependencies that Jacob's using) and am still not seeing any issues. Since the problem appears to affect rendering the images on the webpage, I'm wondering if it's actually a browser issue? What browser versions do you have? Chrome: 112.0.5615.165 |
|
@ThomasSchellenbergNextCentury For me this seems like a timing issue. Might be worth mentioning that my human input mode has been one step behind for a while now. When I went through things on this branch, it seemed like when I made a step, the new image would load in the specified directory AFTER the reference to the older one was already sent as the "up to date" version in the HTML. Additionally, sometimes the image hadn't even finished loading (especially on start) when I looked at things in the network tab, so I would sometimes get a broken image link or half loaded image like Jacob was seeing. I played around with adding time.sleep(0.1) in a couple different places, and that seems to work for me + the most up to date image is loaded fully. We still have the issue of pressing buttons too fast that will cause issues with the images, but I believe that's logged as a separate ticket somewhere for the future. |
rartiss55
reviewed
Jun 15, 2023
| # wait to make sure we've finished loading the new image | ||
| # (not sure why the is_file_open check below didn't | ||
| # do the trick?) | ||
| time.sleep(0.1) |
There was a problem hiding this comment.
I added some logger lines for testing with is_file_open -- this never returned False for me, so not sure if it just doesn't work for me, or the timing is off, or if it works at all? Might be worth revisiting.
rartiss55
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.