AWS Javascript api change v2 to v3 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Jim, I'll start testing this shortly and if all goes well I'll push a release then we can continue the discussion on the other PR. |
|
Of course! Only too happy. The only slightly out of the way issue was that the v3 pricing api returns a json string instead of json, and even though there was an exception it didn't show up in the logs. I tracked it down via your test harness. |
mahdi-torabi
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Again.
These are the changes from your current main (ie without merging my previous pull request) required to upgrade to the AWS v3 apis. The only reason to do this is to suppress the warning in the github UI when the action runs.
If/when you choose to merge my OIDC pull request, some merge conflicts will need to be resolved ... or let me know if when you merge this and I will sort everything out in the OIDC branch so the merge will be clean.
Hope it helps.
All the best
Jim