Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle workflow cancelations and idle runners #25

Merged
merged 7 commits into from
Jul 18, 2024

Conversation

mahdi-torabi
Copy link
Contributor

@mahdi-torabi mahdi-torabi commented Jul 18, 2024

This PR addresses the issue encountered when a workflow is cancelled before any steps have run.

We have introduced a new configuration parameter which defines the maximum amount of time in seconds a runner is allowed to be idle waiting for a job.

  • added github_job_start_ttl_seconds configuration parameter
  • Modified shutdown procedure to include a step for removing runners from GH API
  • Fixed a bug with how InsufficientInstanceCapacity exceptions were being handled.

@mahdi-torabi mahdi-torabi merged commit 656b820 into main Jul 18, 2024
@mahdi-torabi mahdi-torabi deleted the handle_workflow_cancelations branch July 18, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant