Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Next.js app 디렉토리 기반 @tanstack/react-query 설정 #7

Merged
merged 6 commits into from
Jul 18, 2023

Conversation

alstn2468
Copy link
Member

@alstn2468 alstn2468 commented Jul 17, 2023

작업 내용

  • @tanstack/query 관련 라이브러리 설정
  • ThemeProvider, QueryClientProvider 컴포넌트 추가 및 정리
  • app 디렉토리 기반 react-query 프로젝트 설정
  • prettier 버전 변경 (3.0.0 -> 2.8.8)
  • HMR 안되는 이슈 수정 (명령어 문제)

@alstn2468 alstn2468 added the enhancement New feature or request label Jul 17, 2023
@alstn2468 alstn2468 self-assigned this Jul 17, 2023
@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keyme-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 2:16pm

@alstn2468 alstn2468 force-pushed the feat/setup-react-query branch from 95cf998 to f5edbbe Compare July 17, 2023 14:05
@alstn2468 alstn2468 changed the title feat: app 디렉토리 기반 react-query 설정 feat: Next.js app 디렉토리 기반 @tanstack/react-query 설정 Jul 17, 2023
@alstn2468 alstn2468 merged commit 1455579 into main Jul 18, 2023
@alstn2468 alstn2468 deleted the feat/setup-react-query branch July 18, 2023 11:56
Copy link
Contributor

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

민수님 생각이 궁금해요

retry: false,
refetchOnMount: false,
refetchOnWindowFocus: false,
suspense: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alstn2468
https://tanstack.com/query/v4/docs/react/community/suspensive-react-query

@lukemorales/query-key-factory 이 라이브러리도 쓰신다면 전역에 suspense를 기본 옵션으로 사용할 거라면 @suspensive/react-query는 어때요? 타입적으로 좀 더 간결하게 사용할 수 있을 걸로 기대되어서요. 어떤 점을 개선해야할 지 알고 싶어요ㅎㅎ

  1. useSuspenseQuery
  2. useSuspenseQueries
  3. useSuspenseInfiniteQuery

tkdodo님과도 v5에 추가할 때 어떻게 하면 좋을지 트위터에서 같이 이야기하고 alpha버전에서 이 부분 반영할 수 있으면 좋겠는데 여러 의견이 필요해요. 혹시 관심있다면 같이 이야기해보면 좋을 거 같아요.

관련 Pull Request: TanStack/query#5739

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 좋은 의견 감사합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants