You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Our workshop collection memoization functionality is currently exporting incorrect patches/installer options/file lists when a curator publishes a collection - this is a long standing bug which has remained undetected pre-1.11.x as the installation options is a new feature of 1.11.x.
This can only happen when updating and publishing the collection within the same Vortex session.
To Reproduce
User1 creates a fomod with a specific structure and uploads it to the site.
Curator uploads a collection and adds the fomod.
User2 downloads the collection - everything works fine.
User1 changes the fomod structure significantly (i.e. some installer steps become optional or removed entirely) and uploads his update to the site.
Curator downloads the update and uploads a new revision of his collection. Due to memoization functionality in the collections extension, the same fomod options as in the first version of the mod are uploaded as part of the collection instead of the newer generated options.
User2 updates to the new revision of the collection, the install manager attempts to install the mod but will only generate instructions based on the new fomod's structure, ommitting installer options that are not present in the new fomod.
User2 now has a correct installation of the mod which should work fine depending on the new fomod structure, but our installer option comparisons will fail (although the mod is installed correctly)
Expected behavior
Publishing a new revision should ensure we do not publish incorrect metadata as part of the collection.
Screenshots
"choices": {
"type": "fomod",
"options": [
{
"name": "Install Type",
"groups": [
{
"name": "Options",
"choices": [
{
"name": "No Basic Marker", // <---- Selecting this option will not display the "Marker Accessibility" installer step.
"idx": 2
}
]
}
]
},
{
"name": "Marker Accessibility", // <-------- This should not be here.
"groups": [
{
"name": "Marker Options",
"choices": [
{
"name": "Bright White",
"idx": 0
}
]
}
]
},
{
"name": "Thank you for installing",
"groups": [
{
"name": "Thank you",
"choices": [
{
"name": "please make sure you have the right requirements!",
"idx": 0
}
]
}
]
}
]
},
Temporary Workaround for curators
Remove the mod from the collection.
Uninstall the affected mod completely (DO NOT use the re-install functionality as that forwards the installer options)
Install the mod, selecting the wanted options.
Close Vortex
Start Vortex and add the mod to the collection.
Publish a new revision.
Users
The mods that are part of the collection are still installed correctly even though the collection UI is stating that the collection is incomplete - ignore the collection UI and verify the mod installations within the mods page instead.
The text was updated successfully, but these errors were encountered:
To clarify - this fix doesn't change the necessity to check backwards compatibility of curated mods and set the correct 'version' property in the collection.
For example: MyMod version 1 isn't backwards compatible with version 2 as FOMOD installer options were removed. When the collection is curated, the version latest can't be used as the installer options set for v1 won't work on v2. In this case you'd need to use exact so that v1 is always downloaded. If v2 is needed for the collection to work, then v2 will need to be specifically downloaded by the curator and installer options set accordingly before publishing.
Describe the bug
Our workshop collection memoization functionality is currently exporting incorrect patches/installer options/file lists when a curator publishes a collection - this is a long standing bug which has remained undetected pre-1.11.x as the installation options is a new feature of 1.11.x.
This can only happen when updating and publishing the collection within the same Vortex session.
To Reproduce
Expected behavior
Publishing a new revision should ensure we do not publish incorrect metadata as part of the collection.
Screenshots
Temporary Workaround for curators
Users
The mods that are part of the collection are still installed correctly even though the collection UI is stating that the collection is incomplete - ignore the collection UI and verify the mod installations within the mods page instead.
The text was updated successfully, but these errors were encountered: