Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updating mods with pre-release versions #15044

Closed
wants to merge 1 commit into from

Conversation

madtisa
Copy link
Contributor

@madtisa madtisa commented Dec 20, 2023

Let's say we have mod with current version 1.0.0-pre1 and newest 1.0.0-pre2. Coercing would convert both versions to 1.0.0 and update notification won't occur

Let's say we have mod with current version `1.0.0-pre1` and newest `1.0.0-pre2`. Coercing it would convert them both to 1.0.0 == 1.0.0 and update notification won't occur
@IDCs
Copy link
Contributor

IDCs commented Dec 21, 2023

I agree with you completely - but I'm afraid that most of our mod authors (not to mention some game developers) will not abide to semantic versioning. This update will fix the update functionality for some games, yet break it for others.

Until the website is in a position to enforce versioning, I'm afraid that specific line of code will remain as is.

@IDCs IDCs closed this Dec 21, 2023
@madtisa
Copy link
Contributor Author

madtisa commented Dec 21, 2023

Thanks for quick reply. I see what you mean. In this case, since parse has more strict regex than coerce, how about we would try to parse it first, and if version is "incomplete" we coerce:
https://github.com/madtisa/Vortex/blob/db44babc7a4faf127bcac6b629350349ccbb328f/src/extensions/mod_management/util/versionClean.ts#L4
This way, it shouldn't affect versions that doesn't comply to semver, and would allow to update pre-release mods with proper versions

@madtisa
Copy link
Contributor Author

madtisa commented Dec 21, 2023

Also submitted PR to semver. Hopefully, it would be possible to coerce pre-releases in future by using options

@madtisa
Copy link
Contributor Author

madtisa commented Dec 22, 2023

@IDCs, I'm not familiar with the process of a discussion in this project. Should I create new PR for latest change or is it going to be reviewed in this one eventually? Or should I mention the change in the opened issue and wait?

@madtisa
Copy link
Contributor Author

madtisa commented Jan 6, 2024

@IDCs, PR to node-semver has been approved, but it will take quite some time until it's released. Hopefully, next discussion in PR won't be ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants