Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reactions. #181

Closed
dessalines opened this issue Apr 26, 2020 · 3 comments
Closed

Support reactions. #181

dessalines opened this issue Apr 26, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@dessalines
Copy link

Is your feature request related to a problem? Please describe.

Riot has had reactions for a while, and they're in the spec now. A few other clients support them but not Nheko yet.

@dessalines dessalines added the enhancement New feature or request label Apr 26, 2020
@deepbluev7
Copy link
Member

relates to #134.

Also, reactions are sadly not in the spec yet. Until they are, I'm probably not going to work on it, since the current spec proposal doesn't match at all what Riot/Web and RiotX implement and even Riot/Web and RiotX differ in some aspects. The current proposal for relations is a minefield of issues, you can read more about that here: matrix-org/matrix-spec-proposals#1849

But multiple people expressed interest in implementing this feature in Nheko, so it may come in the near future and I will help out in some capacity. It's just that MSC1849 is really bad currently and since Riot implemented it, everyone thinks, that they are finished, while it is still an alpha or beta feature :D

@dessalines
Copy link
Author

dessalines commented Aug 10, 2020

Just a note, I see the button there now for react, but when I click it, it does nothing. The current reacts are shown tho!

0.7.2-4887730 | Linux

@deepbluev7
Copy link
Member

This is done, although the emoji picker likely needs a bit of polish still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants