Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 bit integer frame size for USLT ?? #18

Closed
algoshipda opened this issue Aug 18, 2020 · 3 comments
Closed

32 bit integer frame size for USLT ?? #18

algoshipda opened this issue Aug 18, 2020 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@algoshipda
Copy link
Contributor

I found lyrics is mis-decoding.

With some debugging, I found the fact that USLT actually uses 32bit integer for frame size.
(what about the other frame?)

If we change USLT frame size to 32 bit integer instead of the sync safe integer, it works.

@algoshipda algoshipda added the bug Something isn't working label Aug 18, 2020
@algoshipda
Copy link
Contributor Author

@NiKoTron
Copy link
Owner

@algoshipda Thanx for the report!

I read both specs again, and according to this docs 2.3 uses not sync safe value for size - https://id3.org/id3v2.3.0#ID3v2_frame_overview
but 2.4 sync-safe - https://id3.org/id3v2.4.0-structure (paragraph 4)

I don't know why they changed it but ok, looks like I'm going to implement it.

@NiKoTron NiKoTron added this to the v0.3.1 milestone Aug 19, 2020
@NiKoTron
Copy link
Owner

I've implemented a separate size calculation for v2.3 and v2.4.
It should be fixed in this commit - d637088

NiKoTron added a commit that referenced this issue Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants