fix(dex): fix calculation of stableswap swaps and add tests #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasmatt
changed the title
Unique-Divine
approved these changes
Jan 25, 2023
| @@ -76,14 +77,43 @@ func TestSwapExactAmountIn(t *testing.T) { | |||
| PoolAssets: []types.PoolAsset{ | |||
| {Token: sdk.NewInt64Coin("unusd", 3_010_778_598), | |||
There was a problem hiding this comment.
note to self: use denom constants from x/common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Swaps are broken currently on master for stableswap. The invariant calculations are correct, but instead of computing
y when x = x + dxand returningy - y_after, it's calculatingy when x = dxand then returningy_after.this pr fix that, and add simple swap test to make sure that stableswap are working.
Purpose
fix a big issue