Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: asset registry #1158

Merged
merged 12 commits into from
Jan 26, 2023
Merged

feat: asset registry #1158

merged 12 commits into from
Jan 26, 2023

Conversation

k-yang
Copy link
Member

@k-yang k-yang commented Jan 25, 2023

Description

  • adds an AssetRegistry to manage our supported denoms and pairs
  • replaces hard-coded common.Pair_* usages with the AssetRegistry

Purpose

Helps us manage more assets in an efficient manner going forward.

@k-yang k-yang requested a review from a team as a code owner January 25, 2023 16:47
@k-yang k-yang self-assigned this Jan 25, 2023
Unique-Divine
Unique-Divine reviewed Jan 25, 2023
View reviewed changes
Copy link
Member

@Unique-Divine Unique-Divine left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing your PR with another PR:

Unique-Divine and others added 2 commits January 25, 2023 18:22
@Unique-Divine @k-yang
refactor(asset_registry): Use set[string] instead of slice `[]strin…
bd0f7ea 
…g`, since it covers both use cases (#1159)

* refactor(asset_registry): Use StringSet instead of []slice, since it
covers both use cases

* feat: add generic sets (#1160)

* feat(set): use a generic set instead of StringSet

* chore: update changelog

Co-authored-by: Kevin Yang <5478483+k-yang@users.noreply.github.com>
@k-yang
Merge branch 'master' into feat/asset-registry
1a28c7d
@k-yang k-yang enabled auto-merge (squash) January 26, 2023 00:31
@k-yang k-yang disabled auto-merge January 26, 2023 00:33
@k-yang k-yang enabled auto-merge (squash) January 26, 2023 00:42
@k-yang k-yang merged commit ab96d89 into master Jan 26, 2023
@k-yang k-yang deleted the feat/asset-registry branch January 26, 2023 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unique-Divine Unique-Divine Unique-Divine approved these changes

Assignees

@k-yang k-yang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-yang @Unique-Divine