Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(perp): multi liquidate #1195

Merged
merged 12 commits into from
Feb 13, 2023
Merged

feat(perp): multi liquidate #1195

merged 12 commits into from
Feb 13, 2023

Conversation

k-yang
Copy link
Member

@k-yang k-yang commented Feb 12, 2023 •
edited
Loading

Description

  • wire in multi-liquidate
  • add test coverage
  • add liquidation failed events
  • returns a non-zero status code when all liquidations in the multi liquidate fail

Purpose

Liquidations are necessary for perps.

@k-yang k-yang requested a review from a team as a code owner February 12, 2023 04:57
@k-yang k-yang self-assigned this Feb 12, 2023
@k-yang k-yang added fix/bug epic Project or large task that groups multiple tickets and PRs labels Feb 12, 2023
@k-yang k-yang enabled auto-merge (squash) February 12, 2023 15:12
@k-yang k-yang requested a review from tj327 February 12, 2023 15:44
tj327
tj327 reviewed Feb 13, 2023
View reviewed changes
proto/perp/v1/tx.proto Outdated Show resolved Hide resolved
tj327
tj327 reviewed Feb 13, 2023
View reviewed changes
proto/perp/v1/tx.proto Outdated Show resolved Hide resolved
tj327
tj327 reviewed Feb 13, 2023
View reviewed changes
x/perp/client/cli/tx.go Outdated Show resolved Hide resolved
@k-yang k-yang merged commit 8d464cf into master Feb 13, 2023
@k-yang k-yang deleted the feat/multi-liquidate branch February 13, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unique-Divine Unique-Divine Unique-Divine approved these changes

@tj327 tj327 Awaiting requested review from tj327

@onikonychev onikonychev Awaiting requested review from onikonychev

Assignees

@k-yang k-yang

Labels
epic Project or large task that groups multiple tickets and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k-yang @tj327 @Unique-Divine @onikonychev