Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reduce gas on openposition #1237

Merged
merged 15 commits into from
Mar 29, 2023
Merged

feat: reduce gas on openposition #1237

merged 15 commits into from
Mar 29, 2023

Conversation

jgimeno
Copy link
Contributor

@jgimeno jgimeno commented Mar 23, 2023 •
edited
Loading

Description

What does this PR do?

Reduces gas on open position at least 12% in the simplest open position call.

Purpose

Why is this PR important?

@jgimeno jgimeno marked this pull request as ready for review March 28, 2023 17:32
@jgimeno jgimeno requested a review from a team as a code owner March 28, 2023 17:32
matthiasmatt
matthiasmatt approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@matthiasmatt matthiasmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, i had a feeling we were checking 10.000 times if the vpool exists. this also simplify testing

@jgimeno jgimeno enabled auto-merge (squash) March 29, 2023 08:00
@jgimeno jgimeno merged commit 459a604 into master Mar 29, 2023
@jgimeno jgimeno deleted the feat/open-position-improve branch March 29, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasmatt matthiasmatt matthiasmatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgimeno @matthiasmatt