Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pricefeed): Renamed from property to avoid python name clash #737

Merged
merged 1 commit into from
Jul 23, 2022
Merged

fix(pricefeed): Renamed from property to avoid python name clash #737

merged 1 commit into from
Jul 23, 2022

Conversation

john-connor84
Copy link
Contributor

from is a reserved word in python so the proto class gets generated without the property

@john-connor84 john-connor84 requested a review from a team as a code owner July 22, 2022 23:35
@NibiruHeisenberg NibiruHeisenberg merged commit 53482c8 into master Jul 23, 2022
@NibiruHeisenberg NibiruHeisenberg deleted the jc/from branch July 23, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NibiruHeisenberg NibiruHeisenberg NibiruHeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-connor84 @NibiruHeisenberg