Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: run integration test when pr is approved #795

Merged
merged 4 commits into from
Aug 5, 2022
Merged

ci: run integration test when pr is approved #795

merged 4 commits into from
Aug 5, 2022

Conversation

AgentSmithMatrix
Copy link
Contributor

No description provided.

@AgentSmithMatrix AgentSmithMatrix requested a review from a team as a code owner August 4, 2022 14:56
@AgentSmithMatrix AgentSmithMatrix changed the title run integration test when pr is approved ci: run integration test when pr is approved Aug 4, 2022
@matthiasmatt
Copy link
Contributor

image

I can still merge while integration tests on approved PR are running. Is that expected behavior?

@matthiasmatt matthiasmatt self-requested a review August 4, 2022 18:38
@AgentSmithMatrix
Copy link
Contributor Author

We shouldn't, I wonder if we can overcome this.

@AgentSmithMatrix
Copy link
Contributor Author

done, good point @matthiasmatt !!

@AgentSmithMatrix AgentSmithMatrix merged commit 9907222 into master Aug 5, 2022
@AgentSmithMatrix AgentSmithMatrix deleted the ci/integration-on-pr-approved branch August 5, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasmatt matthiasmatt Awaiting requested review from matthiasmatt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AgentSmithMatrix @matthiasmatt @NibiruHeisenberg