feat(oracle): remove tobin tax #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testinginprod
changed the title
| @@ -16,7 +16,7 @@ message GenesisState { | |||
| repeated MissCounter miss_counters = 4 [(gogoproto.nullable) = false]; | |||
| repeated AggregateExchangeRatePrevote aggregate_exchange_rate_prevotes = 5 [(gogoproto.nullable) = false]; | |||
| repeated AggregateExchangeRateVote aggregate_exchange_rate_votes = 6 [(gogoproto.nullable) = false]; | |||
| repeated TobinTax tobin_taxes = 7 [(gogoproto.nullable) = false]; | |||
| repeated Pair pairs = 7 [(gogoproto.nullable) = false]; | |||
There was a problem hiding this comment.
The Pair message only contains a string. Maybe it would be cleaner to get rid of the Pair message and just use repeated string here.
There was a problem hiding this comment.
I'd rather do this in a follow up PR just to keep PRs scope small in order to avoid having reviewability issues, I'll create a follow up issue.
NibiruHeisenberg
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #806