feat: add pair to vpool snapshot get and set functions #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be better to add the PairID to the snapshot key than to iterate over all snapshots and grab the one that matches the desired PairID. |
|
Superseded by #925 |
auto-merge was automatically disabled
September 16, 2022 16:02
Pull request was closed
Unique-Divine
deleted the
922-bug-perp-cant-open-position-on-master-when-theres-more-than-1-vpool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a pair value for the vpool snapshot in proto and tests. This fix a bug where the snapshot returned by the get function were random when there was more than one vpool.
Purpose
Current master branch does not allow a user to open a position if there's more than on vpool set in the genesis.