refactor: custom chain for mainnet

[CalicoNino]

Bringing back #249 for mainnet, this replaces a lot of custom string url manipulations in https://github.com/NibiruChain/web-app/pull/813

[coderabbitai]

Walkthrough

The recent updates involve mathematical adjustments to a quadratic equation in the StableSwap documentation, interface enhancements to include an optional mainnet property in ChainIdParts, and updates to the CustomChain class for endpoint URL construction. Additionally, new test cases have been added to verify the CustomChain instance properties and the queryChainIdWithRest function.

Changes

File Path	Change Summary
.../docs/classes/StableSwap.md	Updated mathematical expressions in the quadratic equation and its iterative solution.
.../src/chain/chain.ts	Added mainnet property to ChainIdParts interface; updated endpoint URL construction in CustomChain class.
.../src/test/chain.test.ts	Added new test cases for "Mainnet" and queryChainIdWithRest.

Poem

🐇 CodeRabbit hopped along, 🌟
Spying changes, none too wrong.
With math tweaked and tests anew,
Chains entwine, as versions grew. 🔄

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can reply to a review comment from CodeRabbit.
• You can also chat with CodeRabbit bot directly around the specific lines of code or files in the PR by tagging @coderabbitai in a new comment.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 4c38b2d and b389092.

Files ignored due to filter (1)

• package.json

Files selected for processing (3)

• packages/nibijs/docs/classes/StableSwap.md (1 hunks)
• packages/nibijs/src/chain/chain.ts (3 hunks)
• packages/nibijs/src/test/chain.test.ts (1 hunks)

Additional comments: 8

packages/nibijs/docs/classes/StableSwap.md (2)

• 178-185: The updated mathematical expression in the documentation should accurately reflect the implemented algorithm in the code. Verify that the changes to the quadratic equation are correct and consistent with the source code. If the documentation is intended to explain the code's logic, any discrepancy could lead to misunderstandings about how the system operates.

• 178-185: While the changes to the mathematical expression are clear, it's not evident how they relate to the PR's objective of refactoring for a custom chain configuration for the mainnet. If this documentation change is part of a broader set of changes, ensure that the context and relevance are clear to maintainers and users.

packages/nibijs/src/chain/chain.ts (3)

• 28-33: The addition of the mainnet property to the ChainIdParts interface is a significant change to the public API. Ensure that all parts of the codebase that instantiate ChainIdParts objects or rely on its properties are updated to handle the new mainnet property correctly.

• 58-68: The logic for constructing endpoint URLs in the CustomChain class now includes a conditional based on the mainnet property. Verify that this logic correctly handles all expected scenarios, including when mainnet is true, false, or undefined.

• 81-83: The initChainId method now uses the filter(Boolean) pattern to construct the chainId. This change should ensure that only truthy values are included in the chainId, effectively ignoring undefined or empty strings. Confirm that this change aligns with the intended behavior for all possible states of chainIdParts.

packages/nibijs/src/test/chain.test.ts (3)

• 53-67: The new "Mainnet" test case correctly creates a CustomChain instance with the mainnet property set to true. The assertions check the properties of the CustomChain instance, ensuring they match the expected values for a mainnet configuration. This aligns with the PR's objective to support a custom chain configuration for the mainnet.

• 69-71: The test case for queryChainIdWithRest is present, but the hunk does not show the actual test implementation. It is important to ensure that the test case correctly tests the queryChainIdWithRest function, especially in the context of the new mainnet configuration.

• 50-71: > Note: This review was outside the patches, so it was mapped to the patch with the greatest overlap. Original lines [1-71]

The existing tests in chain.test.ts appear to be untouched by the new changes, which suggests that the refactoring has not adversely affected the existing functionality. However, it is crucial to run the entire test suite to confirm that the changes have not introduced any regressions.