feat: implement handling for closing transitions #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feature-wise this appears to be ready. Just need to update the tests to account for all the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to support the new feature coming to the main project where closing transitions will be supported (by essentially adding a timeout before removing the transitioning class).
This also has a happy side effect of me realizing that Bootstrap 5 has a unique way of transitioning opening/closing of root level menus, so it'll add support for that as well.
A new option will be passed called
bootstrapTransitions(defaulttrue) that will mimic the way bootstrap handles opening/closing menus along with adding support for the--am-transition-durationcustom prop. Passingfalsefor this option will allow you to use the accessible-menu way of transitioning menus open/closed- which will require custom styling on top of bootstrap.