Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move @octokit/plugin-retry to devDependencies #106

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

joshjohanning
Copy link
Contributor

Not sure if it was just me having this problem, but I had this problem both locally and in a Codespace.

node -v && npm -v

v18.11.0
8.19.2

When running a fresh clone and setup:

npm install
npm run build

src/utils/clients/core.ts:9:23 - error TS7016: Could not find a declaration file for module '@octokit/plugin-retry'. '/Users/joshjohanning/Repos/ghas-enablement-clean/node_modules/@octokit/plugin-retry/dist-node/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/octokit__plugin-retry` if it exists or add a new declaration (.d.ts) file containing `declare module '@octokit/plugin-retry';`

9 import { retry } from "@octokit/plugin-retry";
                        ~~~~~~~~~~~~~~~~~~~~~~~


Found 1 error in src/utils/clients/core.ts:9

When running this which adds this as to devDependencies instead, it works:

npm i --save-dev @octokit/plugin-retry

Builds:

npm run build

> github-helper@1.0.0 build
> npx tsc

@NickLiffen NickLiffen self-requested a review March 21, 2023 12:00
@NickLiffen
Copy link
Owner

lgtm 👍

@joshjohanning
Copy link
Contributor Author

:shipit: ?

😄

@NickLiffen NickLiffen merged commit bb0d086 into NickLiffen:main Mar 24, 2023
@joshjohanning joshjohanning deleted the patch-1 branch March 24, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants