Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features & Refactors #64

Merged
merged 7 commits into from
May 10, 2022
Merged

Features & Refactors #64

merged 7 commits into from
May 10, 2022

Commits on May 9, 2022

  1. chore: 🔧 Rename repos.json

    This change is to allow repos.json & organizations.json to be added
    to gitignore so that privacy can be maintained in private organizations.
    djthornton1212 committed May 9, 2022
    Configuration menu
    Copy the full SHA
    478c86e View commit details
    Browse the repository at this point in the history
  2. feat: ✨ Add missing java codeql file

    Not sure if this was intentional, but a java codeql file doesn't exists.
    This commit introduces the file
    djthornton1212 committed May 9, 2022
    Configuration menu
    Copy the full SHA
    255e469 View commit details
    Browse the repository at this point in the history
  3. chore: ⬆️ Update deps

    Update documentation. `Yarn add` expects a package. The equivalent of npm
    install (install all deps)ya is `yarn install` or just `yarn`
    
    See: https://classic.yarnpkg.com/lang/en/docs/cli/install/
    djthornton1212 committed May 9, 2022
    Configuration menu
    Copy the full SHA
    5c61a99 View commit details
    Browse the repository at this point in the history
  4. feat: ✨ Simplify destDir, user, add root

    This commit attempts to simplify the determination of the destination
    directory and username. It also introduces the root for user home to be
    used in later feature.
    djthornton1212 committed May 9, 2022
    Configuration menu
    Copy the full SHA
    6f8525c View commit details
    Browse the repository at this point in the history
  5. refactor: ♻️ command refactor

    This commit is largely a refactor of the existing code. The point is to
    simplify the commands required for windows/macos/linux. They largely
    all use the same commands with slight variations, such as home
    directory, and command arguments.
    
    It is a larger commit than I'd like, but all three file changes do go
    together.
    
    globals.ts:
    - Removes the need to create separate vars for windows vs
    everything else. Determine the differences in globals and send 1 var.
    - Determine OS here so we can set root to home path. No longer needed
    in commitFile.ts
    
    commands.ts:
    - Squash windows/macOS/linux into a single command array.
    - Introduce platform and root to differ commands/paths
    - Remove unnecessary commands like mv as cp can accomplish this
    - Make commands/arguments conditional
    - Add helper function to convert linux paths to windows paths
      - This really helps with mkdir as Windows can natively create
        multi-leveled directory structures when correct paths are used: `\`
    
    commitFile.ts:
    - Moved existsSync, os and isCodespace to globals.ts
    - Replaced mac/windowsCommands w/ genearlCommands
    - Simplified gitCommands condition
    - Added informs
    - Added try catch to "for loop" of commands. I may just be missing it,
      but the If (stderr) block didn't seem to be activating. The app would
      die after stating the error.
    - Whitelist function for known error responses like this folder alredy
      exists and can't delete a folder that doesn't exists.
    
    The whitelist function feels hacky, so I welcome any thoughts on it.
    djthornton1212 committed May 9, 2022
    Configuration menu
    Copy the full SHA
    cabf7e9 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. feat: ✨ ISSUE-61 PR comments

    This commit contains the recommended changes from Nick.
    
    1. globals consolidates all OS types to a common cwd under destdir
    2. The commands.ts file consolidates all commands into a single list
    3. Backticks are used in string block.
    
    Also introduces user specified temp directory. It turns out I don't
    have a ~/Desktop thanks to OneDrive.
    
    ISSUE-61
    djthornton1212 committed May 10, 2022
    Configuration menu
    Copy the full SHA
    8d6dd4c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from caregility/ISSUE-61-enhancements

    feat: ✨ ISSUE-61 PR comments
    djthornton1212 authored May 10, 2022
    Configuration menu
    Copy the full SHA
    fe87a95 View commit details
    Browse the repository at this point in the history