-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features & Refactors #64
Merged
Merged
Commits on May 9, 2022
-
This change is to allow repos.json & organizations.json to be added to gitignore so that privacy can be maintained in private organizations.
Configuration menu - View commit details
-
Copy full SHA for 478c86e - Browse repository at this point
Copy the full SHA 478c86eView commit details -
feat: ✨ Add missing java codeql file
Not sure if this was intentional, but a java codeql file doesn't exists. This commit introduces the file
Configuration menu - View commit details
-
Copy full SHA for 255e469 - Browse repository at this point
Copy the full SHA 255e469View commit details -
Update documentation. `Yarn add` expects a package. The equivalent of npm install (install all deps)ya is `yarn install` or just `yarn` See: https://classic.yarnpkg.com/lang/en/docs/cli/install/
Configuration menu - View commit details
-
Copy full SHA for 5c61a99 - Browse repository at this point
Copy the full SHA 5c61a99View commit details -
feat: ✨ Simplify destDir, user, add root
This commit attempts to simplify the determination of the destination directory and username. It also introduces the root for user home to be used in later feature.
Configuration menu - View commit details
-
Copy full SHA for 6f8525c - Browse repository at this point
Copy the full SHA 6f8525cView commit details -
This commit is largely a refactor of the existing code. The point is to simplify the commands required for windows/macos/linux. They largely all use the same commands with slight variations, such as home directory, and command arguments. It is a larger commit than I'd like, but all three file changes do go together. globals.ts: - Removes the need to create separate vars for windows vs everything else. Determine the differences in globals and send 1 var. - Determine OS here so we can set root to home path. No longer needed in commitFile.ts commands.ts: - Squash windows/macOS/linux into a single command array. - Introduce platform and root to differ commands/paths - Remove unnecessary commands like mv as cp can accomplish this - Make commands/arguments conditional - Add helper function to convert linux paths to windows paths - This really helps with mkdir as Windows can natively create multi-leveled directory structures when correct paths are used: `\` commitFile.ts: - Moved existsSync, os and isCodespace to globals.ts - Replaced mac/windowsCommands w/ genearlCommands - Simplified gitCommands condition - Added informs - Added try catch to "for loop" of commands. I may just be missing it, but the If (stderr) block didn't seem to be activating. The app would die after stating the error. - Whitelist function for known error responses like this folder alredy exists and can't delete a folder that doesn't exists. The whitelist function feels hacky, so I welcome any thoughts on it.
Configuration menu - View commit details
-
Copy full SHA for cabf7e9 - Browse repository at this point
Copy the full SHA cabf7e9View commit details
Commits on May 10, 2022
-
This commit contains the recommended changes from Nick. 1. globals consolidates all OS types to a common cwd under destdir 2. The commands.ts file consolidates all commands into a single list 3. Backticks are used in string block. Also introduces user specified temp directory. It turns out I don't have a ~/Desktop thanks to OneDrive. ISSUE-61
Configuration menu - View commit details
-
Copy full SHA for 8d6dd4c - Browse repository at this point
Copy the full SHA 8d6dd4cView commit details -
Merge pull request #2 from caregility/ISSUE-61-enhancements
feat: ✨ ISSUE-61 PR comments
Configuration menu - View commit details
-
Copy full SHA for fe87a95 - Browse repository at this point
Copy the full SHA fe87a95View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.