Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @NickLiffen
We finally got our GitHub Advanced Security licenses so we are going to start rolling out code-scanning to all repos 🎉 .
I wanted to do some final tests and noticed a bug however.
When you introduced the functionality to no longer create pull-requests for repos that already have
code-scanning/analyses
I did a quick test to see if it didn't create a pr anymore on a repo that was already scanned and that worked.Today I tested on some new repo's and I found that a pr was actually never created.
I noticed that when there is no analysis available yet the GitHub Api returns
instead of an empty list, so
data.length
in this case results inundefined
. Perhaps this is something that changed over time.I only changed the condition a bit and now it seems to work (again).
Also I believe that GitHub changed something to the security model because I had to update my app permissions:
I updated the doc accordingly.
Kind regards,
Jors