Better errors #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not good at nix, apparently 2 with statements interfere. Good luck figuring it out, I can't rn
Previously, as mentioned in #8, broken assertions in the zig code would generate cryptic error messages. A bunch of these assertions however could be triggered by user behavior, like accidentally trying to include a plugin twice, or through an incorrect assumption in nixpkgs. In situations like these, I now have more sensible readable error messages with potential fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, as mentioned in #8, broken assertions in the zig code would
generate cryptic error messages. A bunch of these assertions however
could be triggered by user behavior, like accidentally trying to include
a plugin twice, or through an incorrect assumption in nixpkgs.
In situations like these, I now have more sensible readable error
messages with potential fixes.
Besides this, I found a small bug in customSubs, which I have a hotfix for. I don't know nix well enough :')