ICU4N.Resources: Include Newtonsoft.Json binaries so we don't conflict with consumers #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces.PackJsonSerializer.targets file to package Newtonsoft.Json.dll inside of our .nupkg files so we don't interfere with referencing Newtonsoft.Json in the consuming project or one of its transitive dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICU4N.Resources + ICU4N.Resources.NETFramework4.0: Added
ICU4N.Resources.PackJsonSerializer.targetsfile to package Newtonsoft.Json.dll inside of our .nupkg files so we don't interfere with referencing Newtonsoft.Json in the consuming project or one of its transitive dependencies.This will prevent any potential DLL hell issues that would happen for end users if we have a private dependency on Newtonsoft.Json.
Newtonsoft.Json is MIT licensed, and we are packing the license file with the DLL.